Skip to content

chore: declare e2e coverage variants in one place - #16845

Open
Nic-Polumeyv wants to merge 10 commits into
version-3from
e2e-variants
Open

chore: declare e2e coverage variants in one place#16845
Nic-Polumeyv wants to merge 10 commits into
version-3from
e2e-variants

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

A coverage variant such as SVELTE_ASYNC or ROUTER_RESOLUTION is declared once, in the app's playwright.config.js through configure(); KIT_E2E_VARIANT selects it per run, and CI rows carry it as data next to project and shard. The per-variant scripts at three layers go, and webServer.env is no longer hand-written per app. Coverage is unchanged: playwright test --list per row is identical up to the project-name suffix. The basics server spec from #16872 runs as its own server:dev and server:build rows instead of inside every basics leg, so the matrix has 28 rows. Which rows run, and with which variant, is a row edit from here: #16861.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 19, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 3c97241:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/3c97241bb4543b6c8fd3a4bf78ebd97733bee076

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16845

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3c97241

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@Nic-Polumeyv
Nic-Polumeyv force-pushed the e2e-variants branch 2 times, most recently from 1d54a06 to d944f0f Compare August 19, 2026 05:26
@Nic-Polumeyv
Nic-Polumeyv marked this pull request as ready for review August 19, 2026 15:24
Base automatically changed from shard-basics to faster-tests August 19, 2026 16:31
Base automatically changed from faster-tests to version-3 August 20, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant