chore: declare e2e coverage variants in one place - #16845
Open
Nic-Polumeyv wants to merge 10 commits into
Open
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/3c97241bb4543b6c8fd3a4bf78ebd97733bee076Open in |
|
Nic-Polumeyv
force-pushed
the
e2e-variants
branch
2 times, most recently
from
August 19, 2026 05:26
1d54a06 to
d944f0f
Compare
Nic-Polumeyv
marked this pull request as ready for review
August 19, 2026 15:24
Nic-Polumeyv
force-pushed
the
e2e-variants
branch
from
August 19, 2026 16:38
5934db2 to
1aa4828
Compare
Nic-Polumeyv
force-pushed
the
e2e-variants
branch
from
August 20, 2026 17:31
1aa4828 to
fd51a51
Compare
…nd drop the per-variant scripts
Nic-Polumeyv
force-pushed
the
e2e-variants
branch
from
August 20, 2026 17:44
fd51a51 to
67c9b90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A coverage variant such as
SVELTE_ASYNCorROUTER_RESOLUTIONis declared once, in the app'splaywright.config.jsthroughconfigure();KIT_E2E_VARIANTselects it per run, and CI rows carry it as data next toprojectandshard. The per-variant scripts at three layers go, andwebServer.envis no longer hand-written per app. Coverage is unchanged:playwright test --listper row is identical up to the project-name suffix. The basics server spec from #16872 runs as its ownserver:devandserver:buildrows instead of inside every basics leg, so the matrix has 28 rows. Which rows run, and with which variant, is a row edit from here: #16861.