fix: dispose Cloudflare platform proxy when Vite servers close - #16976
Closed
svelte-triage-bot[bot] wants to merge 2 commits into
Closed
svelte-triage-bot[bot] wants to merge 2 commits into
svelte-triage-bot[bot] wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/2ad1f7ed00e4a6b017749952a5c06a20f7ba10cdOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 2ad1f7e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Sep 23, 2026
teemingc
marked this pull request as ready for review
September 23, 2026 17:35
teemingc
previously approved these changes
Sep 23, 2026
teemingc
dismissed
their stale review
September 23, 2026 17:38
checking if #16754 already fixed this
|
|
||
| describe('virtual workers module', () => { | ||
| test('disposes the platform proxy when the dev server closes', async () => { | ||
| const plugin = adapter().vite?.plugins?.pre?.[0]; |
Contributor
Member
|
already fixed by #16754 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16919
The Cloudflare adapter no longer creates its platform proxy during builds, but the proxy created for Vite dev and preview servers was still retained after those servers closed.
This change retains the proxy in the adapter plugin and disposes it:
closeBundlelifecycle for dev serversclose()lifecycleAdded focused tests covering dev and preview teardown and a patch changeset.
Verification:
pnpm -F @sveltejs/adapter-cloudflare test:unitpnpm -F @sveltejs/adapter-cloudflare checkpnpm -F @sveltejs/kit test:unitpnpm checkpnpm lintworkerdprocesses before and after