chore: give scroll and focus their own state and tests - #16983
Merged
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/18d73524174167d0a7d8b82983f2d5e3d9dd1f20Open in |
🦋 Changeset detectedLatest commit: 18d7352 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nic-Polumeyv
force-pushed
the
client-focus-module
branch
from
August 31, 2026 03:25
4386cd6 to
2b735ad
Compare
Nic-Polumeyv
force-pushed
the
client-focus-design
branch
2 times, most recently
from
September 1, 2026 18:34
8081c8a to
889a452
Compare
teemingc
force-pushed
the
client-focus-module
branch
from
September 7, 2026 05:38
01f7ffb to
fad9a52
Compare
teemingc
force-pushed
the
client-focus-design
branch
from
September 7, 2026 05:38
889a452 to
b75501c
Compare
teemingc
force-pushed
the
client-focus-design
branch
from
September 8, 2026 11:58
b75501c to
d014d17
Compare
Nic-Polumeyv
force-pushed
the
client-focus-design
branch
from
September 17, 2026 19:18
d014d17 to
8bc76fe
Compare
Nic-Polumeyv
removed this pull request from stack #16984
September 19, 2026 13:29
teemingc
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #16980:
scroll.jsowns the after-navigation scroll andfocus.jsowns the blur and the focus reset, withfinish_navigationthe one place that sequences them. Whether the app moved focus during the update is now read fromdocument.activeElementdirectly instead of a snapshot taken before the update, and a navigation that does not reset no longer scrolls to where it already is.A focused SVG element is now blurred before the DOM update like any HTML element.