Skip to content

fix: generate types on dev server startup - #17034

Merged
teemingc merged 3 commits into
version-3from
triage/kit-17032-generate-types-on-dev-start
Sep 19, 2026
Merged

teemingc merged 3 commits into
version-3from
triage/kit-17032-generate-types-on-dev-start

Conversation

@svelte-triage-bot

Copy link
Copy Markdown
Contributor

Fixes #17032.

Synchronizes generated files and route types during Vite dev-server initialization, before any request is received. Parameter matcher validation remains deferred because it requires the initialized Vite SSR runner.

Adds a regression test that starts a real Vite development server without making a request and verifies route types already exist.

Tests:

  • pnpm -F @sveltejs/kit test:unit
  • pnpm -F @sveltejs/kit check
  • pnpm -F @sveltejs/kit prepublishOnly
  • pnpm lint
  • pnpm format

@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from c717143:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/c717143bdf42d05e6cf81d660a8d76afc927ed60

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17034

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c717143

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc

teemingc commented Sep 3, 2026

Copy link
Copy Markdown
Member

@svelte-triage-bot investigate the failing CI job

@dummdidumm

Copy link
Copy Markdown
Member

@svelte-triage-bot you failed at the above request, investigate why through your feedback tool

@svelte-triage-bot

Copy link
Copy Markdown
Contributor Author

I’m analyzing the failed workflow handling and recording the findings in the bot feedback tracker.

@dummdidumm

Copy link
Copy Markdown
Member

@svelte-triage-bot you failed at the above request, investigate why through your feedback tool

@svelte-triage-bot

Copy link
Copy Markdown
Contributor Author

I’ve started a feedback analysis of the failed CI-investigation handling.

@teemingc

Copy link
Copy Markdown
Member

@svelte-triage-bot investigate the failing CI test

@svelte-triage-bot

Copy link
Copy Markdown
Contributor Author

I found the failing job: Windows test:kit:unit (matrix 24). I’ve started a focused reproduction to determine whether the new dev-server type-generation test is responsible.

@teemingc
teemingc marked this pull request as ready for review September 19, 2026 00:07
@teemingc
teemingc merged commit df3f003 into sveltejs:version-3 Sep 19, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated types aren't created on vite dev startup

2 participants