docs: expand Config types on vite reference page - #17041
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/2016f060129044a5730649e077733cf0c124727aOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Severity of issue fixed: Low Merge Risk: 🔵 Low · up to The Config type reference metadata is restored, but a remaining Markdown lint warning in the page can prevent documentation validation from completing cleanly. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
I think that's been removed in the |
There was a problem hiding this comment.
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
🟡 Other comments (1)
documentation/docs/98-reference/15-@sveltejs-kit-vite.md-6-6 (1)
6-6: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winRemove the blank line between the metadata directives.
markdownlintreports MD028 at Line 6. Keep theMODULEandEXPANDED_TYPESdirectives in one contiguous blockquote.Proposed fix
> MODULE: `@sveltejs/kit/vite` - > EXPANDED_TYPES: `@sveltejs/kit/vite`#ConfigSource: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: QUIET
Plan: Advanced
Run ID: e03a8f55-9861-4fb2-a445-86e90bc78f69
📒 Files selected for processing (1)
documentation/docs/98-reference/15-@sveltejs-kit-vite.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
sveltejs/vite-plugin-svelte(manual)vitejs/vite(manual)sveltejs/svelte(manual)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
1dc90a4 to
f61f6da
Compare
Add EXPANDED_TYPES for @sveltejs/kit/vite#Config so each option gets its own heading in On-this-page. Follows review feedback to expand on the vite page instead of restoring 50-configuration.md. The existing /docs/kit/configuration redirect to @sveltejs-kit-vite preserves hashes, so old configuration#... links land on the expanded sections. Closes sveltejs#17028
3f743e3 to
e7ca9aa
Compare
closes #17028
2c4e73d moved Config to @sveltejs/kit/vite and deleted the configuration page with it, so the docs lost the left-nav entry and the per-option On-this-page anchors (everything collapsed under a single #Config). This puts the page back, pointing EXPANDED_TYPES at @sveltejs/kit/vite#Config. The 31 existing (configuration#...) links in 18 files resolve again.
Heads up: svelte.dev sync-docs still looks for Config/KitConfig in @sveltejs/kit, so it'll need a companion tweak to read Config from @sveltejs/kit/vite (it throws before preprocess runs on version-3). Happy to follow up there.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
Changesets
Edits