chore: inline edge function config - #17058
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/6196b46bfe87a2edceb5d58c582c4ab8e8350360Open in |
🦋 Changeset detectedLatest commit: 7ed7a47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2583499 to
0d5f3c0
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe adapter now generates Netlify edge-function configuration inside the edge entry module. Merge Risk: 🔵 Low · up to Edge configuration now moves into the generated function module, but the regression test does not protect the intended omission of preferStatic. This is a bounded test-coverage gap with low merge risk. 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
Full details: Backward Compatibility Impact DisclosureExplanation The change removes the Resolution Update Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
🟡 Other comments (1)
packages/adapter-netlify/test/apps/edge/build.test.js-18-18 (1)
18-18: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winAssert that
preferStaticis omitted.The edge path now passes
falsetogenerate_config_export, but this test does not verify that contract. A regression that restorespreferStatic: truewould still pass.Proposed assertion
expect(edge_function).toContain('excludedPath:'); +expect(edge_function).not.toContain('preferStatic: true');
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: QUIET
Plan: Advanced
Run ID: 07345bb8-0db8-4ab5-b500-2c576e124f85
📒 Files selected for processing (3)
.changeset/tidy-edges-inline.mdpackages/adapter-netlify/index.jspackages/adapter-netlify/test/apps/edge/build.test.js
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
sveltejs/vite-plugin-svelte(manual)vitejs/vite(manual)sveltejs/svelte(manual)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.
Moves Netlify edge function configuration from
config.jsoninto the generated function module