Skip to content

feat: hardware wallets settings#1032

Merged
ovitrif merged 6 commits into
masterfrom
feat/hw-wallet-settings
Jun 18, 2026
Merged

feat: hardware wallets settings#1032
ovitrif merged 6 commits into
masterfrom
feat/hw-wallet-settings

Conversation

@ovitrif

@ovitrif ovitrif commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Closes #1026
Refs #998

This PR adds a Hardware Wallets settings screen for viewing and managing paired devices, reachable from Settings under General › Payments.

Description

  • Adds a "Hardware Wallets" row to Settings ▸ General ▸ Payments whose value shows the paired-device count and opens the new screen.
  • Adds the Hardware Wallets settings screen: a list of paired devices (connection badge that turns green when connected, device name, balance) each with a per-row delete, plus an "Add Hardware Wallet" button that opens the existing Connect Hardware flow.
  • Removing a device reuses the existing confirm dialog ("your funds are safe…"); the view-model's removal state is now scoped to the tapped device so per-row delete targets the right one.
  • Extracts the shared HW wallet UI components.

Figma Designs:

Preview

Walkthrough Empty State
walletssettings2x.mp4
no design in figma yet, requested

QA Notes

Manual Tests

  • 1. Settings → General → Payments: "Hardware Wallets" row shows with the paired-device count.
  • 2. Settings → tap Hardware Wallets: each paired device is listed with a connection badge, name and ₿ balance; a connected device shows a green badge.
  • 3a. Hardware Wallets → tap a device's trash icon: confirm dialog appears explaining funds are safe.
    • 3b. tap Cancel: the device stays listed.
    • 3c. tap trash again → Remove: the device is removed and the Settings "Hardware Wallets" count decrements.
  • 4. Hardware Wallets → tap Add Hardware Wallet: the Connect Hardware intro sheet opens.
  • 5. No paired devices → Hardware Wallets: empty state and the Add Hardware Wallet button are shown.

Automated Checks

  • Unit tests updated: device-scoped removal dialog in HwWalletViewModelTest.kt (stores the tapped device, clears it on dismiss/remove, and delegates removal with the right id).
  • Journey added: settings-hardware-wallets.xml drives the count row, device list, Add sheet and per-row delete against the Trezor emulator.
  • CI: standard compile, unit test, and detekt checks run by the PR bot.

@greptile-apps

This comment has been minimized.

greptile-apps[bot]

This comment was marked as resolved.

@ovitrif ovitrif changed the title feat: add hardware wallets settings screen feat: hardware wallets settings Jun 18, 2026
@ovitrif ovitrif self-assigned this Jun 18, 2026
@ovitrif ovitrif added this to the 2.4.0 milestone Jun 18, 2026
chatgpt-codex-connector[bot]

This comment was marked as resolved.

@ovitrif ovitrif force-pushed the feat/hw-wallet-settings branch from ed6dec7 to cd799ce Compare June 18, 2026 15:23
@ovitrif ovitrif requested review from jvsena42 and piotr-iohk June 18, 2026 16:09

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-reviewed and updated accordingly

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ovitrif ovitrif merged commit 65db306 into master Jun 18, 2026
17 checks passed
@ovitrif ovitrif deleted the feat/hw-wallet-settings branch June 18, 2026 17:28

@piotr-iohk piotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK
Samsung s22 (Android 16) + Trezor Safe 7 (USB + BLE)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardware Wallet settings

3 participants