Add linux-loong64 prebuilt binary#20294
Conversation
Signed-off-by: 吴小白 <296015668@qq.com>
Confidence Score: 5/5This looks safe to merge.
Reviews (2): Last reviewed commit: "Update crates/node/npm/linux-loong64-gnu..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| target: loongarch64-unknown-linux-gnu | ||
| strip: loongarch64-linux-gnu-strip |
There was a problem hiding this comment.
When the new loongarch64-unknown-linux-gnu matrix entry reaches build:platform, it runs without the --use-napi-cross flag used by the other Linux GNU cross targets. If napi-rs relies on that wrapper to set cross C toolchain variables, native dependencies can compile for the runner or fail to link, leaving the LoongArch GNU package without a usable binary.
| [target.loongarch64-unknown-linux-gnu] | ||
| linker = "loongarch64-linux-gnu-gcc" | ||
| [target.loongarch64-unknown-linux-musl] | ||
| linker = "loongarch64-linux-musl-gcc" |
There was a problem hiding this comment.
The new musl target tells Cargo to use loongarch64-linux-musl-gcc, but the release workflow only installs the GNU LoongArch compiler and relies on Zig for musl builds. Any build path that honors this linker setting will fail before producing @tailwindcss/oxide-linux-loong64-musl because that executable is not installed.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis PR adds LoongArch64 Linux support for the native node bindings. It updates the release workflow to build gnu and musl targets, installs the needed GNU toolchain for one target, configures Rust linker settings, adds new npm package manifests and READMEs, registers the new targets in the Node package metadata, and copies the built artifacts into the release package layout. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/node/npm/linux-loong64-gnu/README.md`:
- Around line 1-3: The README title is using the wrong package identifier;
update the heading in the loong64 README to match the actual package name used
by this binary. Use the existing `@tailwindcss/oxide` loongarch64 description as
context, but change the title from the arm64 variant to
`@tailwindcss/oxide-linux-loong64-gnu` so it is consistent with the package and
the sibling musl README.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a7035baf-ac8e-4e0f-b5b8-3a816b7ce85a
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
.github/workflows/release.ymlcrates/node/.cargo/config.tomlcrates/node/npm/linux-loong64-gnu/README.mdcrates/node/npm/linux-loong64-gnu/package.jsoncrates/node/npm/linux-loong64-musl/README.mdcrates/node/npm/linux-loong64-musl/package.jsoncrates/node/package.jsonscripts/version-packages.mjs
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
1 participant
Add support for the LoongArch 64-bit architecture.