Skip to content

fetch-content: send Accept-Encoding header (bug 2049952) #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcristau wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fetch-content: send Accept-Encoding header (bug 2049952) #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/taskgraph/run-task/fetch-content
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def stream_download(url, sha256=None, size=None, headers=None):
length = 0

t0 = time.time()
req_headers = {}
req_headers = {"Accept-Encoding": "gzip"}
for header in headers:
key, val = header.split(":")
req_headers[key.strip()] = val.strip()
Expand Down
3 changes: 2 additions & 1 deletion test/test_scripts_fetch_content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ def mock_urlopen(req, timeout=None, *, context=None):
assert req._full_url == url
assert timeout is not None
if headers:
assert len(req.headers) == len(headers)
# stream_download adds accept-encoding
assert len(req.headers) == len(headers) + 1
for header in headers:
k, v = header.split(":")
k = k.lower().capitalize().strip()
Expand Down