Conversation
The release workflow installed the deprecated `vsce` package, whose last version (2.15.0) only trusts the defunct vsmarketplacebadge.apphb.com host for SVG badges. After the README moved to vsmarketplacebadges.dev, `vsce package` failed with "SVGs are restricted in README.md". @vscode/vsce 3.x trusts vsmarketplacebadges.dev, so use it from devDependencies via npx in both the package and publish steps, and install with `npm ci` so the lockfile is honoured. Also fix the release asset path, which referenced a non-existent `tag_string` step id instead of `tag_version`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kvyv4yLA7eMxRmEGDhHt4m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Create Release" workflow has failed since the README badges moved to vsmarketplacebadges.dev (#17):
The workflow ran
npm install -g vsce, which resolves to the deprecatedvscepackage. Its last release (2.15.0) only trusts the defunctvsmarketplacebadge.apphb.comhost for SVG badges.@vscode/vsce3.x trustsvsmarketplacebadges.dev.Changes
vscedevDependency with@vscode/vsce3.9.2 and refresh the lockfile.npm ciand runnpx vsce package/npx vsce publish, so the pinned version from the lockfile is used instead of a global install.tag_stringstep id (the step istag_version), so the.vsixwas never attached to GitHub Releases.Verification
npx vsce packagesucceeds locally on this branch and producesvscode-3d-preview-0.2.5.vsix(43 files).npm run compileandnpm run lintpass.Note
The
v0.2.5tag currently points at the failing merge commit, so its release run did not publish. After merging, either move the tag to the newmainhead or bump to 0.2.6 and tag again.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kvyv4yLA7eMxRmEGDhHt4m
Generated by Claude Code