Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review service needs an authenticated way to check artifact support before offering a handoff. Add an optional
/service/v1/capabilitiesendpoint with rotating, digest-only service keys. It reports the supported contract and an empty feature list, so linking and retention remain unavailable until implemented.The endpoint is disabled by default and runs before browser sessions and body parsing. It rejects browser context, duplicate credentials, unexpected paths and bodies, closes rejected incomplete uploads promptly, and limits reads per registered client. Configuration and activation remain separate from this change.
Validation: clean lockfile installation; full TypeScript check and emitted build; UI build; 701 passing tests with 49 opt-in cases pending; targeted ESLint; credential/rotation/rate-limit HTTP tests; and interoperability with the real Go client over locally verified HTTPS. A 150-request loopback sample averaged 2.035 ms (p95 2.417 ms); this is not a production latency estimate.