fix: reconnect anonymizations to recreated source repositories - #852
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting and recreating a GitHub repository under the same name leaves existing anonymizations bound to the deleted repository ID. The editor then cannot load branches, even when the replacement repository has read access.
Add an owner-only Reconnect source repository action that loads fresh metadata and branches without changing the published anonymization. Saving validates the previewed repository identity and selected branch/commit, updates the access binding and internal source reference together, and rebuilds the snapshot under the existing anonymous URL. The old commit does not need to exist in the replacement. Ordinary access retains the saved identity check, and a different repository ID at save time is rejected.
Validation: UI build and lint pass; full suite has 719 passing and 49 pending tests. New backend and browser tests cover explicit reconnection, non-owner rejection, missing old commits, denied access, busy repositories, and identity/connection changes during the operation.
tsc --noEmitreports the same five diagnostics as unmodified main with the same dependencies, in anonymize-utils.ts, GitHubDownload.ts, and webview.ts.