feat(reconciler): filter TaskRun/PipelineRun by spec.managedBy - #1882
Merged
Conversation
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/XL
tekton-robot
added
the
kind/feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1882 +/- ##
==========================================
+ Coverage 62.10% 62.15% +0.05%
==========================================
Files 64 64
Lines 4072 4088 +16
==========================================
+ Hits 2529 2541 +12
- Misses 1264 1266 +2
- Partials 279 281 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
khrm
force-pushed
the
managed-by-filter
branch
3 times, most recently
from
August 13, 2026 01:02
3badbab to
ab870dd
Compare
khrm
commented
Aug 13, 2026
| }, Grafeas: GrafeasConfig{ | ||
| NoteHint: "This attestation note was generated by Tekton Chains", | ||
| }, | ||
| Storage: StorageConfigs{ |
Contributor
Author
There was a problem hiding this comment.
This change is due to gofumt.
6 tasks
khrm
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
khrm
force-pushed
the
managed-by-filter
branch
3 times, most recently
from
August 13, 2026 09:16
71ed838 to
e017145
Compare
Skip signing runs managed by external controllers by filtering on the spec.managedBy field at the informer level. Runs with nil, empty, or "tekton.dev/pipeline" managedBy are always accepted. Additional values can be allowed via the "filter.managed-by" key in chains-config. Signed-off-by: Khurram Baig <khurram.baig@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Khurram Baig <kbaig@redhat.com>
khrm
force-pushed
the
managed-by-filter
branch
from
August 14, 2026 02:04
e017145 to
2a4777a
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
khrm
commented
Aug 14, 2026
khrm
left a comment
khrm
left a comment
Contributor
Author
There was a problem hiding this comment.
@infernus01 Can you please review and merge this?
infernus01
reviewed
Aug 14, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip signing runs managed by external controllers by filtering on the spec.managedBy field at the informer level. Runs with nil, empty, or "tekton.dev/pipeline" managedBy are always accepted. Additional values can be allowed via the "filter.managed-by" key in chains-config.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes