Raise ValueError for invalid characters in DataURL.from_data - #18
Merged
Conversation
DataURL.from_data would silently accept unquoted, non-percent-encoded data when base64_encoded is False, producing invalid Data URLs (e.g. data with spaces or other reserved characters). Validate the data against the character set a Data URL allows and raise a ValueError instead. Fixes #17
Bump actions/checkout to v7, actions/setup-python to v7, actions/upload-artifact to v7, and actions/download-artifact to v8.
Promotes the unreleased changelog entry to 1.4.0 and updates VERSION, which setup.py reads when building the distribution.
telday
force-pushed
the
claude/issue-and-deps-arpdl8
branch
from
August 10, 2026 23:45
3fc56b6 to
d52a48c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataURL.from_data would silently accept unquoted, non-percent-encoded
data when base64_encoded is False, producing invalid Data URLs (e.g.
data with spaces or other reserved characters). Validate the data
against the character set a Data URL allows and raise a ValueError
instead.
Fixes #17