fix(workflow): a query handler, an update validator, an await condition and a side effect callback can no longer create a command - #810
Merged
Conversation
…on and a side effect callback can no longer create a command
xepozz
marked this pull request as ready for review
September 12, 2026 06:34
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
wolfy-j
approved these changes
Sep 12, 2026
xepozz
force-pushed
the
fix/readonly-callbacks
branch
3 times, most recently
from
September 14, 2026 19:50
79e0e44 to
7c2f5a3
Compare
… call An inbound interceptor could still create a command while unwinding handleQuery or validateUpdate. The guard is a plain flag now and the message names read-only callbacks, so the trace points at the caller. Also drop a ReflectionMethod::setAccessible() call: on PHP 8.5 its deprecation stopped the Unit suite at 965 of 1527 tests.
xepozz
force-pushed
the
fix/readonly-callbacks
branch
from
September 14, 2026 19:51
7c2f5a3 to
7989ab1
Compare
xepozz
force-pushed
the
fix/readonly-callbacks
branch
from
September 16, 2026 14:45
f3f3fe4 to
d5747e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Activation-wide guard for query handlers, update validators, await conditions and side effect
callbacks, behind
FeatureFlags::$readOnlyWorkflowCallbacks.Why?
All four could create commands that are not part of the workflow's sequence, breaking replay.
Checklist
ReadOnlyCallbackTestCase, six cases, four fail on master.