Conversation
The test matrix runs `dload get` in 68 jobs, each asking the GitHub API for release metadata; a registry carried over from the previous run keeps those calls off the rate limit. A cache entry is immutable, so the run_id keeps the key missing and every job saves its own, while restore-keys reads the registry the newest run left behind. Assisted-By: Claude Opus 5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
composer get:binaries, and points DLoad at it throughDLOAD_CACHE_DIR.download-binaries: truecarry the step; unit jobs are untouched.Why?
Four of the five suites download binaries, which is 68 jobs per workflow run asking the GitHub API for release metadata. The restored registry keeps those calls off the rate limit, and serves the stored releases when a check fails anyway.
Review notes
The cache key looks like it can never hit, and that is deliberate: a cache entry is immutable, so
github.run_idkeeps the key missing and lets every job save its own registry, whilerestore-keys: dload-registry-reads the newest one any previous run left behind.inputs.test-commandandstrategy.job-indexare in the key so the 68 parallel jobs do not race for a single entry — without them all but one job fails to save.Checklist