Skip to content

combobox option snippet#3539

Open
GiantRobots wants to merge 1 commit into
mainfrom
ComboboxLabels
Open

combobox option snippet#3539
GiantRobots wants to merge 1 commit into
mainfrom
ComboboxLabels

Conversation

@GiantRobots

Copy link
Copy Markdown
Collaborator

Description & motivation 💭

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@GiantRobots GiantRobots requested a review from a team as a code owner June 11, 2026 15:57
@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Jun 11, 2026 3:57pm

Request Review

@temporal-cicd

temporal-cicd Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

📊 Strict Mode: 10 errors in 1 file (1.1% of 902 total)

src/lib/holocene/combobox/combobox.svelte (10)
  • L155:4: Type 'null' is not assignable to type 'string'.
  • L158:4: Type 'null' is not assignable to type '"search" | "link" | "success" | "error" | "action" | "activity" | "add-square" | "add" | "apple" | "archives" | "arrow-down" | "arrow-left" | "arrow-up" | "arrow-right" | "ascending" | ... 141 more ... | "xmark-square"'.
  • L160:4: Type 'null' is not assignable to type 'keyof T'.
  • L246:4: 'inputElement' is possibly 'null'.
  • L247:4: 'inputElement' is possibly 'null'.
  • L253:14: Argument of type 'string | T | undefined' is not assignable to parameter of type 'string | T'.
  • L258:14: Argument of type 'string | T | undefined' is not assignable to parameter of type 'string | T'.
  • L302:60: Function lacks ending return statement and return type does not include 'undefined'.
  • L395:10: Type 'HTMLLIElement | null' is not assignable to type 'HTMLLIElement'.
  • L395:43: 'menuElement' is possibly 'null'.

Generated by 🚫 dangerJS against d7f81d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant