Skip to content

fix: stabilize private zone CI auth#507

Merged
brendanjryan merged 1 commit into
mainfrom
brendanjryan/fix-ci-playwright
Jun 17, 2026
Merged

fix: stabilize private zone CI auth#507
brendanjryan merged 1 commit into
mainfrom
brendanjryan/fix-ci-playwright

Conversation

@brendanjryan

Copy link
Copy Markdown
Contributor

Summary

  • Add a private-zone e2e helper that retries authorization until the next enabled action appears.
  • Use the helper across private-zone tests that depend on Zone A read authorization.
  • Prevent handled zone authorization status failures from leaking as unhandled page errors.

Motivation

Private-zone CI could time out after clicking Zone A authorization when testnet auth briefly bounced back to the authorize action instead of advancing to the funding or top-up action.

Key design considerations

  • Keep retry behavior inside the e2e helper so individual tests stay focused on the user flow.
  • Preserve existing test timeouts and action selection behavior.
  • Keep the app-side timeout wrapper scoped to clearing timers without changing authorization semantics.

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tempo-docs Ready Ready Preview, Comment Jun 17, 2026 2:27pm

Request Review

@brendanjryan brendanjryan marked this pull request as ready for review June 17, 2026 14:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 389a85a1cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

actions: Action[],
timeout = 120000,
) {
const deadline = Date.now() + timeout

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset the retry deadline after the initial button wait

When the authorize button is slow to become enabled in CI, this deadline is consumed by the preceding toBeVisible/toBeEnabled waits, so callers using the default 120s budget can have only a few seconds—or none—to click and wait for the fund/top-up/deposit action. The previous flow waited for the authorize button, clicked it, and then gave waitForEnabledAction its own 120s window, so this change can reintroduce timeouts exactly in the slow auth path it is meant to stabilize.

Useful? React with 👍 / 👎.

@brendanjryan brendanjryan merged commit 135e11d into main Jun 17, 2026
10 checks passed
@brendanjryan brendanjryan deleted the brendanjryan/fix-ci-playwright branch June 17, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant