fix: stabilize private zone CI auth#507
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 389a85a1cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| actions: Action[], | ||
| timeout = 120000, | ||
| ) { | ||
| const deadline = Date.now() + timeout |
There was a problem hiding this comment.
Reset the retry deadline after the initial button wait
When the authorize button is slow to become enabled in CI, this deadline is consumed by the preceding toBeVisible/toBeEnabled waits, so callers using the default 120s budget can have only a few seconds—or none—to click and wait for the fund/top-up/deposit action. The previous flow waited for the authorize button, clicked it, and then gave waitForEnabledAction its own 120s window, so this change can reintroduce timeouts exactly in the slow auth path it is meant to stabilize.
Useful? React with 👍 / 👎.
Summary
Motivation
Private-zone CI could time out after clicking Zone A authorization when testnet auth briefly bounced back to the authorize action instead of advancing to the funding or top-up action.
Key design considerations