Do not provide inner CONSTANT, Class, Enum, TypeDef and static method. - #48
Open
KengoTODA wants to merge 1 commit into
Open
Do not provide inner CONSTANT, Class, Enum, TypeDef and static method.#48KengoTODA wants to merge 1 commit into
KengoTODA wants to merge 1 commit into
Conversation
According to official styleguide, we should not provide inner CONSTANT, Class, Enum, TypeDef and others. Only top-level Class is enough. https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Providing_Dependencies_With_goog.provide#Providing_Dependencies_With_goog.provide Squashed commit of the following: commit 5727eea Author: Kengo TODA <skypencil@gmail.com> Date: Sun Nov 9 15:05:48 2014 +0800 create Parser instance at timing of `beforeEach` commit 7d9185a Author: Kengo TODA <skypencil@gmail.com> Date: Sun Nov 9 14:44:44 2014 +0800 refactor commit ed7dd24 Author: Kengo TODA <skypencil@gmail.com> Date: Sun Nov 9 14:25:00 2014 +0800 pass all tests commit c5c5ba4 Author: Kengo TODA <skypencil@gmail.com> Date: Sat Nov 8 17:41:22 2014 +0800 implement expected behavior commit aa23820 Author: Kengo TODA <skypencil@gmail.com> Date: Sat Nov 8 17:24:29 2014 +0800 add test case to make requirement clear commit dbf9eca Author: Kengo TODA <skypencil@gmail.com> Date: Sat Nov 8 17:09:08 2014 +0800 make a new file to handle dependencies
Author
|
Maybe we need to improve not only |
Owner
|
@KengoTODA Thanks, I will look later. |
Author
|
I forgot one thing to tell; Here is the official guideline which explains why we need this patch. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for publishing great and useful project! I use it in my daily development with great joy.
Today I have one suggestion to fix an existing bug. This fix helps us to compile my code with latest Google Closure Library. To know about detail of this bug, please refer google/closure-library#317.