Fix #2131: strip anyhow chain from robot JSON error output - #900
Closed
AlexMikhalev wants to merge 1 commit into
Closed
Fix #2131: strip anyhow chain from robot JSON error output#900AlexMikhalev wants to merge 1 commit into
AlexMikhalev wants to merge 1 commit into
Conversation
…2131
format!("{:#}", err) renders the full anyhow chain
(e.g. "outer: middle: db.internal:5432") into the
robot-mode JSON response printed to stdout, potentially
leaking internal implementation details to callers.
Change to format!("{}", err) which renders only the
outermost message. The stderr eprintln! keeps {:#}
since that output is developer-facing, not API-facing.
P2 finding from security sentinel review of PR #2129.
Contributor
Author
|
Closing as superseded. The diff between this branch ( Closes per Shimaguru mass-rebase pass, 2026-08-29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security sentinel (P2, 2026-06-04, PR #2129 review) flagged anyhow chain disclosure in robot-mode JSON error output.
format!("{:#}", err)inemit_robot_error_and_exitrendered the full anyhow chain into stdout JSONformat!("{}", err)— outermost message only, no chain leakageeprintln!("Error: {:#}", err)on stderr is unchanged (developer-facing)One-line change in
crates/terraphim_agent/src/main.rs:1322.Closes terraphim/terraphim-ai#2131 (Gitea issue)
Test plan
cargo check -p terraphim_agentpassescargo fmt -p terraphim_agent -- --checkpassescargo clippy -p terraphim_agentpassescargo test -p terraphim_agentpasses (running)@adf:quality-coordinator please review this security fix.