Fix #2039: add serde(default) to trigger_descriptions and pinned_node_ids - #902
Closed
AlexMikhalev wants to merge 1 commit into
Closed
Fix #2039: add serde(default) to trigger_descriptions and pinned_node_ids#902AlexMikhalev wants to merge 1 commit into
AlexMikhalev wants to merge 1 commit into
Conversation
…_node_ids Refs #2039 Old persisted SerializableRoleGraph JSON written before issue #84 was merged lacked trigger_descriptions and pinned_node_ids fields. Without #[serde(default)], deserialisation failed with a missing-field error, breaking cache warm-up on any deployment with existing snapshots. Adds regression test: strips both fields from a freshly serialised graph, then verifies round-trip deserialisation succeeds with empty collections.
Contributor
Author
|
Closing as superseded. The diff between this branch ( Closes per Shimaguru mass-rebase pass, 2026-08-29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[serde(default)]totrigger_descriptionsandpinned_node_idsfields inSerializableRoleGraphProblem
SerializableRoleGraphfields added by issue #84 lacked#[serde(default)], causing cache warm-up and persistence read-paths that load pre-#84 snapshots to fail with a serde missing-field error.Test plan
cargo test -p terraphim_rolegraph serializable_rolegraph_deserializes_without_trigger_fieldspassescargo clippy -p terraphim_rolegraph -- -D warningspassesRefs terraphim/terraphim-ai#2039 (Gitea)
Generated with Terraphim AI