fix(wallet-setup): remove mutable static secureStorage singleton - #121
Merged
Merged
Conversation
- WalletSetupService cached an externally-injected SecureStorage instance in a mutable static field, set by WdkAppProvider on mount. Multiple WdkAppProviders silently overwrote each other's instance, with no per-provider scoping and no unmount cleanup (#91). - createSecureStorage() is now a config-free call that always returns the same singleton (see storage/secureStorage.ts), so there was nothing left to inject or cache - every method now calls it directly instead of going through setSecureStorage/getSecureStorage. - Drop the now-unused injection wiring from WdkAppProvider and the dead isSecureStorageInitialized() method. - WalletSetupService isn't exported from the package root and WdkAppProviderProps never exposed a secureStorage override, so this is a fully internal refactor with no public API change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91
Summary
Test plan
npm test/npm run lint/tsc --noEmit- all clean.