fix: allow empty strings for optional config variables to prevent crash - #177
Open
webdevsps wants to merge 1 commit into
Open
fix: allow empty strings for optional config variables to prevent crash#177webdevsps wants to merge 1 commit into
webdevsps wants to merge 1 commit into
Conversation
Fixes theam#158. When `.env` contains blank entries for optional variables like `VERCEL_TOKEN`, Zod's `.min(1).optional()` validation strictly rejects the empty string and crashes the API server on boot during `npm run dev`. By removing `.min(1)`, Zod correctly accepts empty strings, allowing downstream code (like `vercel.ts`) to handle them gracefully as unconfigured rather than crashing the entire server on boot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
By removing
.min(1)from optional env variables, Zod correctly accepts empty strings instead of throwing a validation error. This allows downstream code to handle them gracefully as unconfigured.Why
Fixes #158.
When
.envcontains blank entries for optional variables (likeVERCEL_TOKEN), Zod strictly rejects the empty string and crashes the API server on boot.Verification
pnpm verifypasses locally