Skip to content

Remove sample packing step from Node SDK release workflow#23

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:migrate
Jul 9, 2026
Merged

Remove sample packing step from Node SDK release workflow#23
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:migrate

Conversation

@brionmario

@brionmario brionmario commented Jul 9, 2026

Copy link
Copy Markdown
Member

Purpose

$subject

Approach

N/A

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards in WSO2 Secure Coding Guidelines
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

Summary by CodeRabbit

  • Chores
    • Updated the release process for the Node SDK so GitHub releases are now published with generated release notes only.
    • Removed the extra packaged sample archive from the release upload, simplifying the release artifact set.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cf121cad-17f1-4728-97f4-630e3ba0f40f

📥 Commits

Reviewing files that changed from the base of the PR and between a6a3397 and bf0ed20.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release-node job in the GitHub Actions workflow no longer runs the pack-sample step for the Node SDK, and the gh release create command no longer includes the packaged sample archive argument, now using only --generate-notes.

Changes

Release Workflow Update

Layer / File(s) Summary
Simplify release-node GitHub Release step
.github/workflows/release.yml
The gh release create invocation for the Node SDK release drops the archive attachment argument, consistent with removal of the preceding pack-sample step.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description keeps the template but leaves Purpose and Approach as placeholders, so it lacks the required PR-specific details. Replace $subject and N/A with a concrete purpose and approach, and add any relevant issue links, testing, docs, and breaking-change details if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: removing the sample packing step from the Node SDK release workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brionmario brionmario merged commit d59a308 into thunder-id:main Jul 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants