This repository was archived by the owner on Jul 17, 2026. It is now read-only.
ci: fix build-binaries version step; tidy homebrew guard#125
Merged
Conversation
With Changesets the version bump is committed to package.json, so the build-binaries job checks out a v<version> tag that already carries the right version. The old `npm version <v> --no-git-tag-version` step now fails with "Version not changed" and blocks the binary + Homebrew stage. Assisted-by: Claude Opus 4.8 via Claude Code Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MantasMiksys
approved these changes
Jul 3, 2026
The release job only runs on push to main, and build-binaries (which update-homebrew depends on) has no such guard, so the extra `github.ref == 'refs/heads/main'` check was redundant. Assisted-by: Claude Opus 4.8 via Claude Code Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
designcode
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two post-Changesets cleanups to the release workflow:
1. Drop the obsolete
npm versionstep frombuild-binariesUnder semantic-release,
package.jsonstayed at0.0.1in-repo, so the binary job stamped the real version withnpm version <v> --no-git-tag-version. With Changesets the version bump is committed, so the checked-outv<version>tag already has the right version — andnpm version 3.4.0now errors withVersion not changed, failing the job and blocking the binary + Homebrew stage (this is what broke the 3.4.0 binary release).2. Drop the redundant
github.ref == 'refs/heads/main'guard fromupdate-homebrewThe
releasejob only runs onpushtomain, andbuild-binaries(whichupdate-homebrewdepends on) has no such guard, so the extra check was redundant. Now both jobs share the samepublished == 'true'condition.npm publish itself is unaffected — this only unblocks/tidies the binary + Homebrew stage for future releases.
🤖 Generated with Claude Code