Skip to content

Fix Atom dependencies during batch rebuilds - #423

Merged
tim-smart merged 1 commit into
mainfrom
agent/codex-engineer/8b6e89a7
Jul 30, 2026
Merged

Fix Atom dependencies during batch rebuilds#423
tim-smart merged 1 commit into
mainfrom
agent/codex-engineer/8b6e89a7

Conversation

@tim-smart

Copy link
Copy Markdown
Owner

Summary

  • build method-form Atom dependencies before registering their parent edge
  • track invalidation that occurs while a node is rebuilding in a batch and rebuild it again before commit
  • add regression coverage for lost async dependencies and re-entrant batch invalidation
  • add a patch changeset for @effect-atom/atom

Root cause

Lifetime.get registered the parent edge before building the parent, which allowed that build to invalidate the child mid-build and discard the new dependency. Separately, batch rebuilding treated every valid node as complete, even when the node had been invalidated during its own build.

Validation

  • pnpm test --run (104 tests)
  • pnpm lint
  • pnpm check

Closes EFF-231

@tim-smart
tim-smart merged commit 89cd267 into main Jul 30, 2026
3 checks passed
@tim-smart
tim-smart deleted the agent/codex-engineer/8b6e89a7 branch July 30, 2026 10:28
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant