Release v0.5.0 - #178
Merged
Merged
Conversation
For semi-confined aquifers (ilap == 0) in steady models, the vcontour_array method was using aq.z for z-coordinates which includes all layer boundaries (leaky and aquifer), but the arr array only had values for aquifer layers. This caused dimension mismatches or incorrect contour plots. The fix builds a z array that matches the structure of the arr array: - z[0] = top boundary (where head = hstar) - z[1], z[3], ... = aquifer tops - z[2], z[4], ... = aquifer bottoms This ensures dimensions always match and the head values are properly aligned with the z-coordinates. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
- send one model copy per worker - modify disvec signature to match head - parallel progressbars updates per completed chunk - add disvec_array method
inhom1d.py's Xsection.plot already showed leffaq as beta text, but plots.py's separate xsection implementation (used by regular ModelMaq/Model3D models) never had it. leffll (leaky layer beta) is not added here since this branch has no leffll plumbing yet -- that depends on the head_in_leaky_layer work.
Guarded with hasattr since this branch doesn't have leffll plumbed into AquiferData yet (that lands with the head_in_leaky_layer work). Once it is, beta will show for leaky layers here too, same as it already does for aquifers.
self.leffll was referenced unconditionally, but this branch doesn't plumb leffll through AquiferData yet, so plotting params on any confined model with a leaky layer raised AttributeError. Guard with hasattr, consistent with the same guard just added in plots.py.
param_maq's confined/phreatic branch never broadcast leffaq to naq (unlike the leaky-top branch, which does), so leffaq stayed length 1 for any multi-aquifer confined model. Dormant since the original loading-efficiency commit; surfaced now because ml.plots.xsection() and Xsection.plot() both index leffaq[aqi] for aqi up to naq-1.
…Brst/timflow into add-loading-efficiency-plot
Added loading efficiency to leaky layers and a new function to compute the head in the vertical direction, even inside leaky layers. --------- Co-authored-by: dbrakenhoff <d.brakenhoff@artesia-water.nl>
- set Sll to 0.0 if <= 1e-20 - merge dev
…ys, but use correct layer dimensions
Add loading efficiency to xsection plot
Improve parallel performance
- adds reference to top boundary element to steady/transient models (addition for steady is more for uniformity in code, not very useful) - add get_bc method to element to create time series of topboundary condition (nice for plotting) - move ConstantStar creation to Model base class for steady models
mbakker7
self-requested a review
September 9, 2026 08:38
mbakker7
approved these changes
Sep 9, 2026
mbakker7
left a comment
mbakker7
left a comment
Contributor
There was a problem hiding this comment.
After we update the version number, I think we can merge this.
…ethod Top boundary reference and method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking release progress:
Add support for reference time per observation well #168holding on off on this one until I convince Mark this is useful :)Once these are completed, we can make a new release.