fix: make the minimum TLS version explicit - #123
Open
sachaservan wants to merge 2 commits into
Open
sachaservan wants to merge 2 commits into
sachaservan wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly require TLS 1.2 or newer in the synchronous socket wrapper and both pinned TLS contexts, addressing CodeQL #2 without changing certificate verification. Replace the substring-based rejection assertion with the exact expected error for #3.
Add regression coverage for TLS policy and secret-free fallback logging. Alert #1 remains unchanged: it flags the constant environment-variable name, not a secret value.
Summary by cubic
Makes the minimum TLS version explicit: the sync socket wrapper and both pinned SSL contexts now require
TLSv1_2or newer instead of relying onssl.create_default_context()defaults, addressing CodeQL alert #2 without changing certificate verification. The transport origin-rejection test now asserts the exact error message instead of a substring, covering alert #3.Written for commit b91f254. Summary will update on new commits.