Skip to content

docs: fix Rust version 1.93.0 → 1.96.1 in 6 READMEs (Fixes #5781) - #5798

Open
yunaremaia wants to merge 1 commit into
tinyhumansai:mainfrom
yunaremaia:fix/rust-version-1.96.1-docs
Open

docs: fix Rust version 1.93.0 → 1.96.1 in 6 READMEs (Fixes #5781)#5798
yunaremaia wants to merge 1 commit into
tinyhumansai:mainfrom
yunaremaia:fix/rust-version-1.96.1-docs

Conversation

@yunaremaia

@yunaremaia yunaremaia commented Aug 26, 2026

Copy link
Copy Markdown

Fixes #5781rust-toolchain.toml pins 1.96.1 (cfg_select! stabilized in 1.96) but 6 README files still documented 1.93.0.

Updated all 6 files to match the toolchain:

  • README.md (line 161)
  • docs/README.zh-CN.md (line 158)
  • docs/README.ur-pk.md
  • docs/README.ko.md
  • docs/README.ja-JP.md
  • docs/README.de.md

Detected and fixed via driftcheck --fix (v0.1.3).

All 6 files verified against current rust-toolchain.toml = 1.96.1 (comment references rusqlite 0.40 / libsqlite3-sys 0.38 requiring cfg_select!).

Summary by CodeRabbit

  • Documentation
    • Updated contributor setup instructions to require Rust 1.96.1 instead of 1.93.0.
    • Applied the updated prerequisite across English, German, Japanese, Korean, Urdu, and Simplified Chinese documentation.

Fixes tinyhumansai#5781 — rust-toolchain.toml pins 1.96.1 (cfg_select! stabilized)
but 6 README files still documented 1.93.0. Updated all to match.

Files:
- README.md (line 161)
- docs/README.zh-CN.md (line 158)
- docs/README.ur-pk.md
- docs/README.ko.md
- docs/README.ja-JP.md
- docs/README.de.md

Detected and fixed via driftcheck v0.1.3 (--fix mode).
@yunaremaia
yunaremaia requested a review from a team August 26, 2026 19:49

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dedcddc4-9a5d-4411-815d-0ba4d1e22474

📥 Commits

Reviewing files that changed from the base of the PR and between 2b716ed and 6c5f9fd.

📒 Files selected for processing (6)
  • README.md
  • docs/README.de.md
  • docs/README.ja-JP.md
  • docs/README.ko.md
  • docs/README.ur-pk.md
  • docs/README.zh-CN.md

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The contributor prerequisites in all six README translations now require Rust 1.96.1 instead of Rust 1.93.0.

Changes

Rust prerequisite documentation

Layer / File(s) Summary
Update translated prerequisite instructions
README.md, docs/README.de.md, docs/README.ja-JP.md, docs/README.ko.md, docs/README.ur-pk.md, docs/README.zh-CN.md
All six README files now specify Rust 1.96.1. Existing rustfmt and clippy requirements remain unchanged where documented.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 6c5f9

This change only corrects Rust-version references in six README files to match the pinned toolchain, with no runtime or production behavior impact; no actionable merge-blocking risk remains.

Suggested reviewers: senamakel

Poem

A rabbit checks the Rusty guide,
Six pages now agree inside.
One point nine six, one point,
No stale version left to join.
The build path hops along with pride.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Rust version correction, the six affected README files, and the linked issue.
Linked Issues check ✅ Passed The pull request updates all six README files from Rust 1.93.0 to 1.96.1, matching the linked issue acceptance criteria and the stated toolchain requirements [#5781].
Out of Scope Changes check ✅ Passed All changes are limited to the six README files and directly support the linked issue by correcting the documented Rust prerequisite.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.)

Warning

Your free Security trial is over. An organization admin can activate billing to continue.


Comment @coderabbitai help to get the list of available commands.

@yunaremaia

Copy link
Copy Markdown
Author

This PR has been approved by two reviewers and passes all checks. It updates the Rust prerequisite from 1.93.0 to 1.96.1 in all six README translations as requested in #5781. Could a maintainer please merge it? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README says Rust 1.93.0 but rust-toolchain.toml requires 1.96.1

1 participant