feat(lfs): record throughput and latency for the LFS path - #51
Open
brightsparc wants to merge 2 commits into
Open
brightsparc wants to merge 2 commits into
brightsparc wants to merge 2 commits into
Conversation
The LFS surface had metrics only on the read-through upstream
(walgit_lfs_upstream_total); the primary batch, GET, PUT and verify handlers
emitted nothing, and static_object.rs emits nothing at all, so there is no way
to see LFS latency or bytes moved in a running deployment.
Adds walgit_lfs_operation_seconds{op}, walgit_lfs_requests_total{op,result}
and, for the two byte-moving operations, walgit_lfs_bytes_total{op} plus a
walgit_lfs_object_bytes{op} size distribution.
PUT reads the whole body in the handler, so its duration is a true transfer
time. GET returns before the body streams, so its duration is time to first
byte and its byte count comes from the response Content-Length; the helper
says so, since dividing bytes by that histogram would overstate throughput.
Each handler keeps its body in an _inner function so the timing wrapper sees
every early return rather than only the success path.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KaoVaspfci2kQbzQJLTPd7
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LFS surface had metrics only on the read-through upstream (walgit_lfs_upstream_total); the primary batch, GET, PUT and verify handlers emitted nothing, and static_object.rs emits nothing at all, so there is no way to see LFS latency or bytes moved in a running deployment.
Adds walgit_lfs_operation_seconds{op}, walgit_lfs_requests_total{op,result} and, for the two byte-moving operations, walgit_lfs_bytes_total{op} plus a walgit_lfs_object_bytes{op} size distribution.
PUT reads the whole body in the handler, so its duration is a true transfer time. GET returns before the body streams, so its duration is time to first byte and its byte count comes from the response Content-Length; the helper says so, since dividing bytes by that histogram would overstate throughput.
Each handler keeps its body in an _inner function so the timing wrapper sees every early return rather than only the success path.