feat(cli): support shadowing to an existing deployment (DX-831) - #524
Draft
blainekasten wants to merge 2 commits into
Draft
feat(cli): support shadowing to an existing deployment (DX-831)#524blainekasten wants to merge 2 commits into
blainekasten wants to merge 2 commits into
Conversation
Add --target-deployment-id to `tg beta endpoints shadow` so users can attach a pre-existing deployment as a shadow experiment target (matching the API's targetDeploymentId) instead of always creating a new one. Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
Broly Security ScanNote ✅ Clean scan Note Re-scan this PR anytime with
|
Collaborator
Author
|
@cursoragent I don't want to add a new flag for this. Drop |
Contributor
Drop --target-deployment-id. Pass a dep_... (or deployment name) as the first positional to attach an existing deployment; endpoint is inferred. Create-new-deployment still uses endpoint + MODEL. Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
tg beta endpoints shadowcan attach an existing deployment as a shadow target by passing adep_...(or deployment name) as the first positionalENDPOINTarg — parent endpoint is inferred.--target-deployment-idper review feedback.ENDPOINT+MODEL.Usage
Test plan
uv run pytest tests/cli/test_beta_endpoints_shadow.py -v(34 passed)dep_vsep_/ MODEL create-path detectiontg beta endpoints shadow dep_... --rate 0.1Fixes DX-831
Linear Issue: DX-831