Repository navigation
fix(tree): set parent pointer in BinaryTreeNode.replaceChild - #2222
Open
LearnCodeZaid wants to merge 1 commit into
Open
LearnCodeZaid wants to merge 1 commit into
LearnCodeZaid wants to merge 1 commit into
Conversation
replaceChild swapped the child pointer but never updated replacementNode.parent, leaving stale parent links after BST removal of a node with one child (issue 2102) and breaking any code walking parent pointers (issue 1102). Adds regression tests for both issues. Fixes trekhleb#1102 Part of trekhleb#2102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1102. Part of #2102.
replaceChild swapped the child pointer but never assigned replacementNode.parent, leaving stale parent links after BST removal of a single-child node and breaking any traversal relying on parent pointers.
Change: two lines assigning replacementNode.parent = this in both left and right branches.
Tests: added issue-2102 repro (insert 8/3/6, remove 3 then 6, assert both children null) plus a replaceChild re-parenting assertion to BinarySearchTree.test.js.