Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
==========================================
- Coverage 90.49% 90.12% -0.38%
==========================================
Files 141 150 +9
Lines 11419 12714 +1295
==========================================
+ Hits 10334 11458 +1124
- Misses 1085 1256 +171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fix conflicts in EDAC and WCSPH RHS: - adopt mapreduce_neighbor / add_dv_* functional API from origin/main - preserve gradient/force correction splitting from stack (gradient_correction for pressure/shifting, force_correction for free-surface)
…ecycle to restore stack diff
…tion-pressure-conservation # Conflicts: # src/schemes/fluid/entropically_damped_sph/rhs.jl # src/schemes/fluid/weakly_compressible_sph/rhs.jl # src/schemes/structure/structure.jl
…ion' into fix/asymmetric-correction-pressure-conservation # Conflicts: # src/general/corrections.jl # src/schemes/fluid/entropically_damped_sph/rhs.jl # src/schemes/fluid/weakly_compressible_sph/rhs.jl # test/general/corrections.jl # test/general/corrections/gradient.jl # test/general/corrections/kernel.jl
…orrection-configuration # Conflicts: # src/schemes/fluid/entropically_damped_sph/rhs.jl # src/schemes/fluid/weakly_compressible_sph/rhs.jl # src/schemes/structure/structure.jl
…t-correction-configuration # Conflicts: # src/schemes/structure/structure.jl # test/general/corrections/common.jl
# Conflicts: # NEWS.md # docs/src/systems/fluid.md # src/general/custom_quantities.jl # src/schemes/fluid/surface_tension.jl # test/systems/edac_system.jl
# Conflicts: # examples/fluid/dam_break_2d.jl # examples/fluid/dam_break_oil_film_2d.jl # src/general/semidiscretization.jl # src/schemes/fluid/entropically_damped_sph/system.jl # src/schemes/fluid/implicit_incompressible_sph/system.jl # src/schemes/fluid/weakly_compressible_sph/system.jl # test/examples/gpu.jl
svchb
force-pushed
the
integration/corrections-surface-method
branch
from
September 2, 2026 15:40
f160706 to
2f001f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack status
This draft joins two prerequisite lines:
28ed03b469).63807976a2).Merge commit
a94de3ca4ajoins #1282 onto the correction stack. The review delta after that join is9da1756512plus the integration-only test fix2f001f3e76: 15 files, 469 insertions, and 21 deletions. The validation-only #1286 remains related but does not block this PR.Summary
SurfacePressureDifference()support to WCSPH and EDAC through thesurface_pressurekeyword.surface_activity.GradientCorrectionandMixedKernelGradientCorrection, including the asymmetric corrected-pressure paths from the correction stack, and reject unsupported configurations.use_surface_pressure=false.Numerical behavior
The pressure-difference operator removes the constant-pressure free-surface defect. Where surface activity is nonzero, the blended operator is intentionally not pairwise momentum-conservative; boundary and cross-fluid interactions are not blended. The manufactured solution records this residual and confirms that it decreases under refinement.
Validation
45/45.39/39.git diff --checkpasses.