feat(sidebar): make nav groups collapsible; workspace group starts closed#129
Open
dantaspaulo wants to merge 1 commit into
Open
feat(sidebar): make nav groups collapsible; workspace group starts closed#129dantaspaulo wants to merge 1 commit into
dantaspaulo wants to merge 1 commit into
Conversation
…osed NavMain gains optional `collapsible` + `defaultOpen` props. When collapsible, the group label becomes a Collapsible trigger with a rotating chevron; when not (the default), the group renders exactly as before, always open. AppSidebar marks the "Workspace" group as `collapsible :default-open="false"` so it starts closed — with several groups expanded the sidebar competes with the primary flow for attention. Other groups are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sidebar renders every nav group expanded. With the main, posts, workspace
and support groups all open at once, the secondary "Workspace" group (channels,
signatures, labels, assets) competes with the primary flow for attention.
Change
NavMaingains two optional props:collapsible(defaultfalse) — when set, the group label becomes aCollapsibletrigger with a rotating chevron.defaultOpen(defaulttrue) — the initial open state when collapsible.When
collapsibleis not set, the group renders exactly as before (alwaysopen), so every other caller is unaffected.
AppSidebarthen marks only the Workspace group ascollapsible :default-open="false", so it starts collapsed. The main, posts andsupport groups are unchanged.