refactor(sidebar): move Settings from the sidebar footer into the user menu#147
Open
dantaspaulo wants to merge 1 commit into
Open
refactor(sidebar): move Settings from the sidebar footer into the user menu#147dantaspaulo wants to merge 1 commit into
dantaspaulo wants to merge 1 commit into
Conversation
…r menu Settings lived on its own fixed row at the bottom of the sidebar. It's a secondary destination, so it now sits inside the user dropdown (above Profile), where it groups naturally with Profile / Language / Log out and frees a fixed row of sidebar space. - UserMenuContent: Settings item added above Profile. - AppSidebar: footer Settings block removed, along with the now-unused IconSettings, settingsHub and useActiveUrl/urlIsActive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Settings lived on its own fixed row at the bottom of the sidebar. It's a
secondary destination, so it took a permanent row of sidebar space for a link
that's rarely the main action.
Change
Settings now sits inside the user dropdown (above Profile), where it groups
naturally with Profile / Language / Log out and frees that fixed sidebar row.
UserMenuContent.vue— Settings item added above Profile.AppSidebar.vue— footer Settings block removed, along with the now-unusedIconSettings,settingsHubanduseActiveUrl/urlIsActive.