Skip to content

Pass ground metadata to schematic solver - #3448

Merged
mohan-bee merged 1 commit into
mainfrom
fix/pass-ground-metadata-to-schematic-solver
Aug 26, 2026
Merged

mohan-bee merged 1 commit into
mainfrom
fix/pass-ground-metadata-to-schematic-solver

Conversation

@mohan-bee

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Aug 26, 2026 8:41am

Request Review

@imrishabh18 imrishabh18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use for this? why only ground and not power?

@mohan-bee

mohan-bee commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor Author

What is the use for this? why only ground and not power?

i need that metadata for this fix to avoid GND string hacks.

tscircuit/schematic-trace-solver#919

i don't find any need for power here right now.

@mohan-bee
mohan-bee requested a review from imrishabh18 August 26, 2026 09:12
@mohan-bee
mohan-bee merged commit 5978290 into main Aug 26, 2026
19 checks passed
@mohan-bee
mohan-bee deleted the fix/pass-ground-metadata-to-schematic-solver branch August 26, 2026 10:17
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


This branch was successfully deployed

1 active deployment
Preview — 16e57d9e Deployed Aug 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants