Skip to content

Fix portable bus routing and remove the ARM-only snapshot job - #4259

Merged
seveibar merged 2 commits into
docs/bus-lanes-integrated-dogbonesfrom
fix/bus-lanes-portable-routing
Sep 30, 2026
Merged

seveibar merged 2 commits into
docs/bus-lanes-integrated-dogbonesfrom
fix/bus-lanes-portable-routing

Conversation

@seveibar

@seveibar seveibar commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

AM3352 routing snapshots currently require a dedicated ARM runner because native Math.hypot rounding changes equal-length shortcut choices on x86. bus-lanes-solver #6 fixes the routing-distance calculation and includes a regression that fails on x86 before the fix.

Use the released solver 0.0.3 from jscdn and return AM3352 to the normal ubuntu-latest test shards. Remove the dedicated ARM job and the shard exclusion. The TSX fixture, three routed snapshots, 169 assertions, DRC gates, and zero image-diff tolerance are unchanged.

Validation: all ten regular x86 test shards, formatting, smoke test, and deployment checks are green (CI run). The AM3352 shard passed in 11m48s with the existing snapshots and all routing assertions unchanged. Full AM3352 also passes on ARM with 47/47 signals and zero native errors; six focused bus_lanes integration tests and the packaged dist build/smoke test pass.

This PR targets the integration branch from merged #4237 (parent #4232 is still open) to keep the diff to two files. Solver #6 is merged; the dependency now points to https://jscdn.tscircuit.com/@tscircuit/bus-lanes-solver/0.0.3.tgz. Its JavaScript bundle and TypeScript declarations are byte-identical to the preview validated above. Installation and all six focused bus_lanes tests pass with the released tarball.

@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tscircuit-core-benchmarks Ready Ready Preview Sep 30, 2026 11:30pm UTC

Request Review

@seveibar
seveibar merged commit 6b138a5 into docs/bus-lanes-integrated-dogbones Sep 30, 2026
15 checks passed
@seveibar
seveibar deleted the fix/bus-lanes-portable-routing branch September 30, 2026 23:44
seveibar added a commit that referenced this pull request Oct 1, 2026
* docs: plan integrated dogbones and constrained bus lane routing

* docs: specify standalone dogbone fanout and local via handoffs

* Route all 47 AM3352 signals with the public bus_lanes phase (#4237)

* Integrate bus lane pipeline and add original-pad AM3352 regression

* Update bus lanes solver to preserve existing fanout handoffs

* Gate AM3352 bus lanes on reference routing quality

* Verify all 47 AM3352 routes and snapshot each signal layer

* Install built bus-lanes props preview consistently in CI

* Run dense AM3352 snapshots in a dedicated ARM job

* Use portable bus lane solver and restore AM3352 to x86 CI

* Use released bus lanes solver from jscdn

* Fix portable bus routing and remove the ARM-only snapshot job (#4259)

* Use portable bus lane solver and restore AM3352 to x86 CI

* Use released bus lanes solver from jscdn

* Avoid idle component rendering while asynchronous routing runs

* Publish a core preview for end-to-end SVG performance validation

* Resolve the preview solver before installing dependencies

* Validate compact route quality and refresh the optimized solver preview

* Use released solver and connectivity packages in AM3352 integration

* Automatically dogbone only unrouted pads without a new prop

* Align preview build with the tested Bun 1.4 runtime

This branch was successfully deployed

1 active deployment
Preview — 407c6275 Deployed Sep 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant