Add board viaPlugging process selection - #876
Open
techmannih wants to merge 2 commits into
Open
techmannih wants to merge 2 commits into
techmannih wants to merge 2 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional board prop
viaPluggingto select the via-hole plugging process for a future manufacturing order. A boolean records whether plugging is requested but cannot identify the process.JLCPCB’s technical guide, under “Are there any size limits for plugged vias?”, groups ink, epoxy, and copper paste as plugging processes. The prop preserves their distinct processes:
solder_mask_inkepoxy_filled_and_cappedcopper_paste_filled_and_cappedTented and Untented are not values of this prop.
defaultViaTentingremains the existing tenting control; ink plugging and filled-and-capped processes are not treated as physically identical.Values are preserved without aliases or automatic defaults. Omission leaves the process unspecified, and existing boards require no migration. Core will serialize the selection as
pcb_board.via_pluggingfrom tscircuit/circuit-json#846 and check for explicit exposed board defaults conflicting with the ink-plugging option. This supersedes the boolean-only proposal in #866.Generated documentation is updated. Renderer changes, fabrication-rule validation, and ordering integration are outside this Props PR.
Validation: 575 tests pass, including two focused tests for all three processes, stampboard inheritance, omission, tenting preservation, and invalid inputs. Typecheck, build, formatting, and circular dependency checks pass.