Recover missing J4.5 trace to routed divider junction - #895
Closed
Sang-it wants to merge 7 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sang-it
force-pushed
the
fix/j4-direct-tap-label-fallback
branch
from
August 25, 2026 22:36
70c7584 to
e56bd8f
Compare
Sang-it
changed the title
Sang-it
force-pushed
the
fix/j4-direct-tap-label-fallback
branch
from
August 25, 2026 23:05
e56bd8f to
3342602
Compare
Sang-it
changed the title
Sang-it
force-pushed
the
fix/j4-direct-tap-label-fallback
branch
from
August 25, 2026 23:13
3342602 to
b1221a2
Compare
Sang-it
force-pushed
the
fix/j4-direct-tap-label-fallback
branch
from
August 25, 2026 23:24
b1221a2 to
e3f6b21
Compare
Sang-it
force-pushed
the
fix/j4-direct-tap-label-fallback
branch
from
August 25, 2026 23:29
e3f6b21 to
cfdb832
Compare
Sang-it
force-pushed
the
fix/j4-direct-tap-label-fallback
branch
from
August 26, 2026 18:58
b2bc091 to
7c4d665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- extend the existing NetLabelToTraceSolver recovery stage to recognize a local port-only tap whose two direct neighbors already form a routed trace\n- route the missing branch to the host trace label anchor, so J4.5 joins the midpoint between R26 and R27 instead of targeting either resistor pin\n- keep the recovery topology-based and distance-bounded; no selector-specific utility or MSP exception remains\n- expose the final pipeline result through SchematicTracePipelineSolver.getOutput()\n- make Circuit JSON snapshots use the solver output before intermediate pipeline stages\n\n## Root cause\n\nNetLabelToTraceSolver only created recovery candidates between two port-only labels. In this repro, J4.5 had a port-only fallback label while the matching label was already anchored to the routed R26-R27 trace, so the final recovery stage never considered the trace that could have been drawn between them.\n\nThe snapshot converter also preferred InlineNetLabelSolver output, which is captured immediately before the final recovery stage. Pipeline snapshots now consume the solved pipeline's final output without repro-specific setup.\n\n## Validation\n\n- bun test (216 passed, 4 skipped)\n- bunx tsc --noEmit\n- bun run format:check\n- git diff --check\n\nTargets the reproduction merged in #894.