Preserve explicit ground connections instead of redundant GND branches - #932
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Base automatically changed from
codex/repro-pga300-redundant-ground-traces
to
main
August 26, 2026 11:39
imrishabh18
force-pushed
the
codex/fix-pga300-redundant-ground-traces
branch
from
August 27, 2026 12:34
91b2f49 to
56fb3ea
Compare
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The PGA300 reproduction from #930 is now merged into
main. This PR is rebased onto the latestmain(5091d2f) and contains one fix commit.The global ground spanning tree was replacing the circuit's explicit PGA300 COMP–R1 ground wire with two unnecessary branches: COMP–U1.GND and COMP–C3.
Fix
getGroundConnectionPolicypath used by both the MSP and long-distance solvers.isGround, preserve physical islands defined by explicit pin-to-pin traces.The full-circuit regression now requires the explicit COMP–R1 connection, rejects both redundant branches, verifies all source GND pins remain electrically connected through traces and labels, and preserves the vertical Q1–R1 connection.
Before / after
Before — merged reproduction
After — generated by this PR
Validation
bun test: 280 passed, 4 existing skips, 0 failuresbunx tsc --noEmitbun run buildgit diff origin/main...HEAD --checkAll checks above pass.