Rudimentary Bezier Curves Implementation.#18
Open
TimComm wants to merge 1 commit into
Open
Conversation
|
Why does binomial coeff return double? |
Author
|
Good question, I think I had some integer division bug, turned everything into doubles and missed this one while converting back one by one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently works for cubic curves (degree 3). For it to work for any degree, input points need to be a list. That would change typical usage of the library though, wasn't sure if that's an okay design choice? Was hoping to get some input on that here before I finish figuring out how to create the tests etc.