@tus/s3-store: avoid false completion on generic 404 - #877
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 39e42f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ferhatelmas
had a problem deploying
to
external-testing
September 21, 2026 12:23 — with 
GitHub Actions
Error
GitHub Actions
Error
ferhatelmas
force-pushed
the
s3-store-getupload-not-found
branch
from
September 21, 2026 12:29
b00e254 to
aceb22c
Compare
ferhatelmas
had a problem deploying
to
external-testing
September 21, 2026 12:29 — with
GitHub Actions
Error
GitHub Actions
Error
ferhatelmas
force-pushed
the
s3-store-getupload-not-found
branch
from
September 21, 2026 12:30
aceb22c to
b3e6a48
Compare
ferhatelmas
had a problem deploying
to
external-testing
September 21, 2026 12:30 — with
GitHub Actions
Error
GitHub Actions
Error
ferhatelmas
force-pushed
the
s3-store-getupload-not-found
branch
from
September 21, 2026 12:31
b3e6a48 to
7974303
Compare
ferhatelmas
had a problem deploying
to
external-testing
September 21, 2026 12:31 — with
GitHub Actions
Error
GitHub Actions
Error
related to tus#859 Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
s3-store-getupload-not-found
branch
from
September 21, 2026 12:39
7974303 to
39e42f3
Compare
ferhatelmas
marked this pull request as ready for review
September 21, 2026 12:40
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
|
@Murderlon this is a regression fix, it would be nice to get in so that we can bump the versions, thanks 🙏🏻 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A generic
NotFoundfrom S3ListPartscould makegetUpload()report the full upload offset even when the upload was incomplete. Exclude that error from completion detection while preserving the existingNoSuchUploadandNoSuchKeybehavior.Cover all three error codes through SDK
nameand legacyCodefields, including unchanged propagation of generic errors.Related to #859