Preview for page metadata - #806
Open
manisha1997 wants to merge 2 commits into
Open
Conversation
manisha1997
added a commit
to twilio/twilio-oai-generator
that referenced
this pull request
Sep 2, 2026
…833) Ruby templates always emitted the pagination-metadata scaffolding (list_with_metadata method and the {{apiName}}PageMetadata / {{apiName}}ListResponse classes) for every read operation, even when the List response has no `meta` key and therefore does not support pagination (e.g. ListProfileIdentifiers in Memory v1). Node and Python already gate this on the x-supports-pagination (per-operation) and hasOperationWithPagination (per-resource) extensions computed in ApiResourceBuilder. Apply the same gating in the Ruby templates: - list.mustache: wrap list_with_metadata in x-supports-pagination - api.mustache / parentContext.mustache: wrap the pageMetadata partial in hasOperationWithPagination Regenerated Ruby examples: this removes orphaned PageMetadata/ ListResponse classes that no list_with_metadata referenced. Preview PR - twilio/twilio-ruby#806 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.