Skip to content

Define @SideEffectsOnly; it has no effect yet and is not documented - #7954

Merged
mernst merged 1 commit into
typetools:masterfrom
mernst:side-effects-only-2-5-partial
Aug 10, 2026
Merged

Define @SideEffectsOnly; it has no effect yet and is not documented#7954
mernst merged 1 commit into
typetools:masterfrom
mernst:side-effects-only-2-5-partial

Conversation

@mernst

@mernst mernst commented Aug 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a4cfa633-3230-430a-8d95-b87932b4e120

📥 Commits

Reviewing files that changed from the base of the PR and between ee3de8e and 33ef844.

📒 Files selected for processing (1)
  • checker-qual/src/main/java/org/checkerframework/dataflow/qual/SideEffectsOnly.java

📝 Walkthrough

Walkthrough

Adds the runtime @SideEffectsOnly annotation in the dataflow qualification package. The annotation applies to methods and constructors and supports inheritance by subtypes. Its value() member accepts Java expressions that describe the upper bound on expressions a method or constructor may modify. The documentation defines constructor behavior, expression requirements, and recursive purity constraints.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mernst mernst changed the title Define @SideEffectFree; it has no effect yet and is not documented Define @SideEffectsOnly; it has no effect yet and is not documented Aug 9, 2026
@mernst
mernst merged commit cb0fed3 into typetools:master Aug 10, 2026
21 checks passed
@mernst
mernst deleted the side-effects-only-2-5-partial branch August 10, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant