Propagate qualifier bounds in the correct direction

[mernst]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 07164fa6-2f64-401c-9143-15b4498f57ea

📥 Commits

Reviewing files that changed from the base of the PR and between c1efe65 and 55c29fe.

📒 Files selected for processing (2)

• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/VariableBounds.java
• framework/tests/h1h2checker/QualifierBoundDirection.java

---

📝 Walkthrough

Walkthrough

addConstraintsFromComplementaryBounds now propagates qualifier bounds in the correct direction between inference variables. Lower-bound relationships transfer equal and upper qualifiers as upper bounds. Upper-bound relationships transfer equal and lower qualifiers as lower bounds. The new QualifierBoundDirection test covers these directions, target-typed and untyped inference, and the expected needH1S2 diagnostic.

Possibly related PRs

• typetools/checker-framework#7985: Updates VariableBounds.java for related qualifier constraint propagation logic.

Suggested reviewers: smillst

Merge Risk: ⚪ Minimal · up to 55c29

This localized qualifier-bound propagation change has no actionable merge-blocking risk identified at the current head and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}