Skip to content

Add missing overrides - #8165

Closed
mernst wants to merge 16 commits into
typetools:masterfrom
mernst:dth-missing
Closed

mernst wants to merge 16 commits into
typetools:masterfrom
mernst:dth-missing

Conversation

@mernst

@mernst mernst commented Sep 13, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: dd0e0a2a-aeb7-45ac-8fa4-94447c446dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 8f9dca3 and e368008.

📒 Files selected for processing (1)
  • framework/src/main/java/org/checkerframework/framework/type/DefaultTypeHierarchy.java

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

DefaultTypeHierarchy now has explicit visitor methods for previously unhandled combinations involving arrays, intersections, primitives, type variables, unions, and wildcards. Most new handlers throw new Error("not yet implemented"). visitArray_Primitive performs primary subtype checking, and visitUnion_Primitive delegates to visitUnion_Type. Documentation and comments were also reformatted or clarified.

Suggested reviewers: smillst

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e3680

The added visitor coverage has no established regression and is ready to merge with normal checks.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 33 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@smillst smillst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This methods are intentional not overridden because they are comparisons that should never happen. Because they are not overridden, the super class calls defaultErrorMessage is called for those methods.

@smillst smillst assigned mernst and unassigned smillst Sep 14, 2026
@mernst mernst closed this Sep 14, 2026
@mernst
mernst deleted the dth-missing branch September 14, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants