Clarify JavaParserUtil.resolveTypeName comments

[mernst]

JavaParserUtil.resolveTypeName looks names up in a particular order, because a name in scope shadows one that is not. Document why each lookup is where it is: a type parameter takes precedence over everything, a type in the same package over one in java.lang, and any type in scope over the interpretation of the name as fully-qualified.

Also replace importedName.length() > firstComponent.length() by the equivalent but clearer !importedName.equals(firstComponent): the test is asking whether the import has a qualifier, not comparing lengths.

No behavior change.

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 72e72810-0527-42be-91ed-5b75df57093c

📥 Commits

Reviewing files that changed from the base of the PR and between b87c803 and 61e9632.

📒 Files selected for processing (1)

• framework/src/main/java/org/checkerframework/framework/util/JavaParserUtil.java

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

Updated resolveTypeName comments to document type-parameter shadowing, same-package precedence, and final fully qualified name lookup. Renamed the local variable generic to genericDeclaration. Replaced the static-import guard with an equivalent equality check. No functional behavior changes were made.

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to 61e96

This change only clarifies documentation, renames a local variable, and preserves the existing predicate behavior.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}