Rename arraysAreRelevant to arrayTypesAreRelevant - #8174
Conversation
The field is about array *types*, so name it accordingly. Add a public accessor for it, and document its value directly rather than describing when `isRelevantImpl` happens to consult it. Also document what an override of `isRelevantImpl` must handle: the cases for which the implementation in `GenericAnnotatedTypeFactory` returns true immediately. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Suggested reviewers: Priority: ⬇️ Low Change: Refactor Merge Risk: ⚪ Minimal · up to The API rename is documented and does not introduce an unresolved repository risk, so the change is ready to merge. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
GenericAnnotatedTypeFactory.arraysAreRelevantis about array types, so rename it toarrayTypesAreRelevantand add a public accessor. Its documentation described whenisRelevantImplhappens to consult it; document its value directly instead.Also document what an override of
isRelevantImplmust handle: the implementation inGenericAnnotatedTypeFactoryreturns true immediately for the types inrelevantJavaTypes, and for every type whenrelevantJavaTypes == null, so an override must handle those cases itself or callsuper.The renamed field is
protected, so this is a source-incompatible change for a type system outside this repository; the changelog records it. No type system in this repository referred to the old name.🤖 Generated with Claude Code