Mark the file as modified when WPI removes a declaration annotation - #8175
Merged
mernst merged 2 commits intoSep 16, 2026
Merged
Conversation
`WholeProgramInferenceJavaParserStorage.removeMethodDeclarationAnnotation()` changes the annotations of a source file, but unlike every other mutator in the class (such as the adjacent `addMethodDeclarationAnnotation()`), it did not call `setFileModified()`. If no other change was made to the file, the removal was not written out. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedNext included review available in 24 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The JavaParser storage marks the file as modified when a method declaration annotation is removed; make the scenes (jaif) storage do the same, so the two backends maintain the invariant consistently. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WholeProgramInferenceJavaParserStorage.removeMethodDeclarationAnnotation()changes the annotations of a source file, but unlike every other mutator in the class -- including the adjacentaddMethodDeclarationAnnotation(), which it otherwise mirrors -- it did not callsetFileModified(). If no other change was made to the file, the file was not rewritten and the removal was lost.🤖 Generated with Claude Code