Skip to content

Use the shared WPI output directory helpers in the ainfer-relevance task - #8188

Closed
mernst wants to merge 1 commit into
masterfrom
ainfer-relevance-shared-wpi-helpers
Closed

mernst wants to merge 1 commit into
masterfrom
ainfer-relevance-shared-wpi-helpers

Conversation

@mernst

@mernst mernst commented Sep 16, 2026

Copy link
Copy Markdown
Member

Part 7, splitting #8177 into reviewable pieces. Independent of the rest of the stack and can merge on its own, in parallel with #8182 and #8183.

#8172 and #8176 crossed: #8172 introduced DirectoryDeleter.deleteDirectories and wpiOutputDirectory() and applied them to every ainfer*Generate* task, while #8176 added ainferRelevanceGenerateAjava with its own copy of the inline deletion loop. After both merged, that one task is the only one still carrying the duplicated code.

Use the shared helpers there too, deleting the duplicate.

Build-file change only; no behavior change.

🤖 Generated with Claude Code

Every other `ainfer*Generate*` task deletes the WPI output directory with
`wpiOutputDirectory()` and `DirectoryDeleter`.  This task still inlined an
equivalent loop, which the merge of the commit that introduced those helpers
left behind.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b608c70c-847b-4b8d-a5f7-6c37642a036c

📥 Commits

Reviewing files that changed from the base of the PR and between e405420 and d69fcb8.

📒 Files selected for processing (1)
  • checker/build.gradle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mernst mernst closed this Sep 17, 2026
@mernst
mernst deleted the ainfer-relevance-shared-wpi-helpers branch September 17, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant